hoodiehq / hoodie-account-server

:dog: Account JSON API backed by PouchDB
Apache License 2.0
22 stars 59 forks source link

use complete lodash package instead of lodash.* #33

Closed gr2m closed 8 years ago

gr2m commented 8 years ago

@boennemann says

I would use the complete lodash package for all server side code and the require('lodash/objects/merge') method for client side code:

  1. maintenance is super high for the individual packages
  2. for install time: saves roundtrips, not download size
  3. we are deduping and bundling all dependencies for the final hoodie build. When lodash is used throughout all components (+greenkeeper) then we'll end up with just one lodash (also in memory). I think that the saved, duplicated metafiles of all the individual packages might have a similar size than the entire build :P
  4. the lodash/*/* method has all the upsides of the individual packages for client side builds, without the package.json and require mess

:)

Sounds good to me

janl commented 8 years ago

https://github.com/hoodiehq/hoodie-server-account/pull/61