search

hoodiehq / hoodie-client

:dog: Client API for the Hoodie server
Apache License 2.0
34 stars 25 forks source link

Update @hoodie/store-client to the latest version 🚀 #118

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 7.0.0 of @hoodie/store-client just got published.

Dependency @hoodie/store-client
Current Version 6.0.2
Type dependency

The version 7.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of @hoodie/store-client. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Release Notes v7.0.0

7.0.0 (2016-12-23)

Bug Fixes

  • remove dependency on localStorage (060f518e)

Breaking Changes

  • The .hasLocalChanges() was removed, see #138. To find out if there are changes that have not yet been replicated to remote, you can use the workaround described in #138

    (060f518e)

Commits

The new version differs by 4 commits .

  • 060f518 fix: remove dependency on localStorage
  • 9a94d08 test: remove .hasLocalChanges()
  • 23e141c chore(package): -humble-localstorage
  • 6d552cd docs(README): remove .hasLocalChanges()

See the full diff.

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

gr2m commented 7 years ago

@Charlotteis have you seen the release notes? We removed the .hasLocalChanges() which also means for Hoodie Client that hoodie.store.hasLocalChanges() has been removed and therefore we should have released a breaking change. We have a few of these upcoming, bundled into https://github.com/hoodiehq/hoodie-client/pull/110 so we release all at once with only one breaking version instead of several.

Can you start a new PR with one commit fix(package): @hoodie/store-client@^7.0.0? That will fix the problem.

Really no biggie at all, just wanted to let you know. Thanks so much for your PR reviews <3

We should probably add more tests to @hoodie/client as it is a dependency that is used directly (and will be a lot more in future), to prevent PRs like this from being merged accidentally? We would kinda re-test things we already test in the dependencies, but we should at least test the public APIs I think ...

gr2m commented 7 years ago

@Charlotteis I’ll quickly do it because I want to move ahead with dropping localstorage today :) w00p

varjmes commented 7 years ago

@gr2m sorry gregor! Christmas had me busy :)