Bring code coverage to 100% (again)

gr2m commented 8 years ago

Since https://github.com/hoodiehq/hoodie-client/issues/46 we had some refactoring and bugfixing, and the code coverage fell down to 91% (that was me, I’m sorry :( )

current status:

$ npm run test:coverage

=============================== Coverage summary ===============================
Statements   : 91.61% ( 131/143 )
Branches     : 87.18% ( 34/39 )
Functions    : 84.38% ( 27/32 )
Lines        : 91.61% ( 131/143 )
================================================================================

After you run npm run test:coverage you can open coverage/lcov-report/index.html in your browser, it will show a lot of details on which parts of the code is not yet covered. There are a few lines not covered in client/lib/init.js, here’s a preview

[x] claim this issue (@mccullagh)
[x] Setup repository locally and make sure that all tests pass
[x] Start a Pull Request #85
[x] write tests until 100% coverage is reached. Check current coverage by running npm run test:coverage
[ ] review & merge

Ping us in the Hoodie Chat or on Twitter if you have any questions

mccullagh commented 8 years ago

I would like to try

gr2m commented 8 years ago

Thanks @mccullagh, it’s all yours :) I’ll be in the Hoodie Chat for the next 4h or so if you have any questions :)

gr2m commented 8 years ago

Thanks for the great work @mccullagh & welcome at Hoodie :) We’ve invited you to Hoodie Contributors team, you should see an invitation at https://github.com/hoodiehq. If you’d like to contribute again to one of Hoodie’s repositories, you can now create a branch instead of forking it, which makes collaboration more seamless.

I’d be great if you could star Hoodie’s main repository, so more people will find out about our work: https://github.com/hoodiehq/hoodie :)

I’d be happy to help you find something else you can contribute to, just let me know if you are interested.

hoodiehq / hoodie-client

Bring code coverage to 100% (again) #79