test(init.js): to reach 100% code coverage.

hoodiehq / hoodie-client

:dog: Client API for the Hoodie server

Apache License 2.0

34 stars 25 forks source link

test(init.js): to reach 100% code coverage. #85

Closed mccullagh closed 8 years ago

mccullagh commented 8 years ago

closes #79

gr2m commented 8 years ago

Wow, that is spot on! Thanks for the great work! Is this your first PR to an open source project?

LGTM. PIng @hoodiehq/maintainers

mccullagh commented 8 years ago

yes - and i realized that there are some spelling mistakes ....

gr2m commented 8 years ago

i realized that there are some spelling mistakes

In the PR? Then best to fix them right away. If you found typos in other places it’d be best start separate pull requests

mccullagh commented 8 years ago

Do i need to do something?

gr2m commented 8 years ago

@mccullagh no you are all good, thanks. Usually we need two people from the maintainers team to comment with "LGTM", only then then approvals/lgtm status will be green.

But as many of our maintainers are currently conferencing through Europe and this PR doesn’t touch actual code, I’ll take advantage of my admin rights and will just merge it in :) Thanks for the great work!