hoodiehq / hoodie-connection-status

:dog: connection status API for the browser
Apache License 2.0
5 stars 10 forks source link

Event names #14

Closed courajs closed 8 years ago

courajs commented 8 years ago

I would prefer disconnect and reconnect to disconnected and reconnected. I don't have any strong evidence, it just feels more natural to me and I have the impression it's the more common way to name events.

gr2m commented 8 years ago

That's a very good point! In fact, I asked the question about event name conventions a while ago myself: http://stackoverflow.com/questions/11450397/javascript-event-naming-conventions

Yeah, I'm in favor for present tense, as all hoodie events are.

varjmes commented 8 years ago

Agree!

gr2m commented 8 years ago

All right, let's do it :) I've set the bug label, let’s fix it :)

gr2m commented 8 years ago

fixed via #16 (ac90f9e)