Closed finnp closed 8 years ago
great work, LGTM!
ping @hoodiehq/maintainers for 2nd review :eyes:
ooopsie accidentally merged https://github.com/hoodiehq/hoodie-connection-status/pull/47 so sorry :( if you could still review and LGTM just to be sure that a 2nd pair of eyes looked through it, that would be great!
part of https://github.com/hoodiehq/hoodie/issues/458
I tried to think of all the steps to migrate this module to the new architecture:
hoodie-connection-status
index.js
toclient/index.js
. I would say we can leave thelib/
andtest/
folder as they are, as this module only has client code?"browser": "client/index.js"
to the package.json just for convenience, so we can continue to dorequire('hoodie-connection-status')
, won’t harm"name"
inpackage.json
to"@hoodie/connection-status"
"hoodiehq/hoodie-client-connection-status"
and replace with"hoodiehq/hoodie-connection-status"
inpackage.json
"hoodiehq/hoodie-client-connection-status"
and replace with"hoodiehq/hoodie-connection-status"
inREADME.md
chore: ...
anddocs: ...
commits. At the end add an empty commit:"publishConfig": {"access": "public"}
topackage.json
(https://docs.npmjs.com/files/package.json#publishconfig, "Scoped packages default to restricted" https://docs.npmjs.com/cli/access#details)Once merged
hoodie-connection-status
in the npm registryCOVERALLS_REPO_TOKEN=... npm run test:coverage & npm run test:coverage:upload
, then on coveralls.io require100%
coverage for success)