#49 code coverage - Githubissues

hoodiehq / hoodie-connection-status

:dog: connection status API for the browser

Apache License 2.0

5 stars 10 forks source link

#49 code coverage #50

Closed seanjohnite closed 8 years ago

seanjohnite commented 8 years ago

Might be pretty much done with the coverage here. I wasn't sure about the best way to mock out the "nets" module, so I did it similarly to how things were mocked out in the "check()" tests. Thoughts?

gr2m commented 8 years ago

A+, well done!

One minor: could you rename cb to callback? We try to avoid abbreviations if possible.

If you could squash your commits to only one test: 100% coverage, then it’s good to go from my side

seanjohnite commented 8 years ago

All set I think!

finnp commented 8 years ago

Awesome, LGTM! :relaxed:

gr2m commented 8 years ago

jap, LGTM :+1: