Turn off bufferify in nets module for requests

[kahlil]

I turned off bufferify in the nets module for request so this module works with Webpack. Please advise if this is OK.

[gr2m]

it doesn’t need the package-lock.json, does it? We’ll add this soon together with the correct Greenkeeper setup

[kahlil]

Sorry package-lock was a mistake. I just use npm5 and it slipped through.

Yes that is how it is turned off. That's how y'all did it in request.js as well. It's just the nets API. Check the docs: https://github.com/maxogden/nets/blob/master/readme.md

Sent from my iPhone

On 10. Jun 2017, at 12:35, Gregor Martynus notifications@github.com wrote:

@gr2m commented on this pull request.

In lib/utils/request.js:

@@ -11,7 +11,8 @@ function request (options) { requestState = internals.nets({ method: options.method, url: options.url,

• timeout: options.timeout
• timeout: options.timeout,
• encoding: undefined does this line turn off bufferify? How?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[gr2m]

okay great. If you have time, can you update the PR to remove the lock file and add a comment to encoding: undefined to explain why it’s there? No worries if not I can clean it up for ya next week

[kahlil]

Sure, will do.

[kahlil]

fixed... how about adding an .editorconfig file?

[gr2m]

cheers! I couldn’t update your PR so it would get auto-closed, but your changes are merged via 2ab7b99

[gr2m]

new version is out: https://www.npmjs.com/package/@hoodie/connection-status

but something didn’t work out with creating the relaese on GitHub, I’ll fix that manually