search

hoodiehq / hoodie-css

Framework for all hoodie sites
http://hoodiehq.github.io/hoodie-css/
31 stars 13 forks source link

feat: accessibility guide #21

Closed varjmes closed 9 years ago

varjmes commented 9 years ago

I have written a guide to accessibility! I think if every contributor read this before contributing, Hoodie would become very accessible. It would be cool to use this whilst building hoodie-css guides to see if it works for people.

:hatching_chick:

nattarnoff commented 9 years ago

@Charlotteis I have a few comments, and lots of love. This is a really great start with very minor additions/clarifications.

gr2m commented 9 years ago

wow amazing work you two!

varjmes commented 9 years ago

@gtarnoff Thank you so much for reviewing! I can't wait to put your suggestions into action :)

varjmes commented 9 years ago

Am sick/working until the weekend so will update everything then, so don't try and merge this please :D

gr2m commented 9 years ago

@Charlotteis oh noes, get well soon!

I've added a "WIP – DO NOT MERGE" just to make sure :)

varjmes commented 9 years ago

After going through all of @gtarnoff's great comments, I've updated the guide. Have also tweaked it a bit so it reads better :)

nattarnoff commented 9 years ago

My only comment (and it isn't about your PR, it's about the site as a whole) is that the left hand navigation violates the color contrast/focus state rules. I'll be around later and can submit a PR for it, but if we are going to tell folks "these are the rules", we should follow them.

varjmes commented 9 years ago

@gtarnoff Yup I've made an issue for that already. Hoodie-css is very much in development and is not used anywhere yet so these things will be fixed before it goes live. Lots of work left to do!

lewiscowper commented 9 years ago

So I would like to merge this soon so that we can start showing it off, but I'm not sure where to link to it from. I originally thought about the contribute page. But now I'm not sure. Just want to double check. Any thoughts @Charlotteis?

nattarnoff commented 9 years ago

I would put it between "customize" and "colours". It isn't secondary information and it is something you don't want retrofitted after you do all the design. screenshot 2015-10-14 08 47 35

lewiscowper commented 9 years ago

That makes sense. I was looking in completely the wrong website for that. Thanks @gtarnoff :+1:

lewiscowper commented 9 years ago

Live here now http://hoodiehq.github.io/hoodie-css/accessibility.html, although there is a ligatures problem that we're aware of, so for example "fi" doesn't get shown properly. We know the fix and will solve it over time.

nattarnoff commented 9 years ago

Getting a 404 on the Slack image under the second code block.

— Sent from Mailbox

On Wed, Oct 14, 2015 at 9:10 AM, Lewis Cowper notifications@github.com wrote:

Live here now http://hoodiehq.github.io/hoodie-css/accessibility.html, although there is a ligatures problem that we're aware of, so for example "fi" doesn't get shown properly. We know the fix and will solve it over time.

Reply to this email directly or view it on GitHub: https://github.com/hoodiehq/hoodie-css/pull/21#issuecomment-148062082

lewiscowper commented 9 years ago

aha, a missing .. Have fixed directly on gh-pages branch. Thanks again @gtarnoff :+1:

varjmes commented 9 years ago

Sorry I missed this!! Thank you @lewiscowper and @gtarnoff :)