search

hoodiehq / hoodie-task-client

client api for asynchronous task queue, using PouchDB for sync
Apache License 2.0
2 stars 9 forks source link

Refactor to work with the new @hoodie-task-server. #36

Closed inator closed 7 years ago

inator commented 7 years ago

@gr2m - ready for your initial review!

gr2m commented 7 years ago

Looks good at first glance. I’d suggest we do add at least one integration test though. We can also do it in a separate PR though, as this lib is not used yet, will keep the PR discussion simpler

inator commented 7 years ago

Looks good at first glance. I’d suggest we do add at least one integration test though. We can also do it in a separate PR though, as this lib is not used yet, will keep the PR discussion simpler

Ok - I agree as a separate PR. I'll need a little guidance on that though if you don't mind. Thanks!

(requested changes done)

gr2m commented 7 years ago

Good work 👍 I’ll create a separate issue for creating an integration test