search

hoodiehq / hoodie-task-client

client api for asynchronous task queue, using PouchDB for sync
Apache License 2.0
2 stars 9 forks source link

Update LICENSE #48

Closed YendyH closed 7 years ago

YendyH commented 7 years ago

I hope I did this properly. I seem to be having difficulties with pull requests. I updated the copyright per the request.

gr2m commented 7 years ago

closing in favour of your other pull request at https://github.com/hoodiehq/hoodie-task-client/pull/49

YendyH commented 7 years ago

Thank you @gr2m , I'm sorry I didn't realize I had done it twice!

gr2m commented 7 years ago

no problem at all, this is exactly why we create these issues, to help new folks find their way around GitHub.com :) It’s been confusing to all of us, you’ll get there – and you are doing great 👍

YendyH commented 7 years ago

Thank you so much! Your feedback is actually very reassuring!! If you don't mind I do have a question. I did a pull request here and the one for Alice In Wonderland (Hacktoberfest?) and when I check my pull requests on my account only the Hacktoberfest pull request shows. Is it just delayed or is there something else I need to do? Sorry for all my questions. Google was not much help...

gr2m commented 7 years ago

how do you check your pull requests on your account? You should see all open pull requests at https://github.com/pulls. The see the closed ones, click on " ✔️ 123 closed" link on top

image

YendyH commented 7 years ago

I thought I was in my account. https://github.com/pulls only shows the one. I'll wait and see maybe it's delayed then if you did receive my pull request. I'll give it a day.

my_pullrequests

gr2m commented 7 years ago

Oh yeah, that looks like a bug! I’d suggest to send this with the screenshot to support@github.com, they’ll appreciate it :)

YendyH commented 7 years ago

Sent. I will let you know when I hear back or if there's any change. Thanks again for all your help!

YendyH commented 7 years ago

@gr2m you are right, it is a bug. It seems to be something they are dealing with, my pull request is now accurate. Thank you for the help!

gr2m commented 7 years ago

thanks for checking in with GitHub support and for letting us know :)