search

hoodiehq / pouchdb-admins

PouchDB plugin to simulate CouchDB’s admin accounts
Apache License 2.0
7 stars 2 forks source link

issue 8 fix, changed from lodash.clone to lodash #10

Closed kazekagegaara closed 8 years ago

kazekagegaara commented 8 years ago

Fix for issue8. Ran npm install and npm test after making the changes.

gr2m commented 8 years ago

looks good now, thanks :+1:

If you don’t mind, could you please change your commits to

to follow our commit conventions. Happy to help with it if you have any questions. Or if you’re busy I can also do it myself :)

kazekagegaara commented 8 years ago

@gr2m so, I do a git pull origin master first. Then I do git commit --amend and change the commit messages, and then I do a git push --force origin issue8, correct?

kazekagegaara commented 8 years ago

Nopes. I need to do a rebase. Trying to figure that out.

kazekagegaara commented 8 years ago

@gr2m I did a rebase and changed the commit messages. Please review. I hope I did it correctly, this was my first rebase. :-)

gr2m commented 8 years ago

perfect, thank you!