search

hoodiehq / pouchdb-admins

PouchDB plugin to simulate CouchDB’s admin accounts
Apache License 2.0
7 stars 2 forks source link

WIP: issue 11 code coverage #13

Closed kazekagegaara closed 7 years ago

kazekagegaara commented 8 years ago

This is for issue #11 . Started working on set.js file. The test passes, but code coverage still shows that if (error) { return reject(error) } (line 22 in set.js) isn't covered.

gr2m commented 8 years ago

Hey Manit, I pushed a few updates because I thought it would be the best way to explain. I added a few notes to the changes, I hope everything makes sense? Please let me know if you have any further questions

gr2m commented 8 years ago

Hey @kazekagegaara, do you still want to finish this up?

minrwhite commented 8 years ago

I think this is failing because nvm 'stable' version has jumped to v7.0.0 and npm packages aren't cleaned out entirely between builds. I'll open an issue.

gr2m commented 7 years ago

@benwhite-deltas can you rebase on master? Is this ready for review or still WIP?

minrwhite commented 7 years ago

Yeah, I'm happy to do that, when I've got 5 mins. WRT WIP, it depends - are we aiming for 100% with this PR?

gr2m commented 7 years ago

we aim for 100% code coverage, but it doesn’t need to be all in this PR

minrwhite commented 7 years ago

Rebased, ready for review/merge.