search

hoodiehq / pouchdb-hoodie-api

:dog: Hoodie-like API for PouchDB
https://hoodiehq.github.io/pouchdb-hoodie-api
Apache License 2.0
44 stars 11 forks source link

`updateOrAdd` could throw more meaningful error when there is no `id` #115

Open rmehner opened 8 years ago

rmehner commented 8 years ago

So we've been using Hoodie in a project like this:

hoodie.store.updateOrAdd({artist: 'Shellac', title: 'Riding Bikes'})

and ran into the following Pouch error which left us a bit baffled for the moment:

pouch-error

Quickly looking up into the code it was clear what happens, but then I was confused because in hoodie-store-client there's code that handles that case and returns a more friendly error message: https://github.com/hoodiehq/hoodie-store-client/blob/e850a59e6e9b5266866b0f9ca1a0f703ce55aa60/lib/scoped/update-or-add.js#L28-L32

Should pouchdb-hoodie-api behave the same?

gr2m commented 8 years ago

yes, I’m already working on this