hoodiehq / pouchdb-hoodie-api

:dog: Hoodie-like API for PouchDB
https://hoodiehq.github.io/pouchdb-hoodie-api
Apache License 2.0
44 stars 11 forks source link

Use custom clone #67

Closed NickColley closed 9 years ago

NickColley commented 9 years ago

PouchDB has replaced the extend usage with a custom clone, noticed pouchdb-extend is being used here.

@nolanlawson , is pouchdb-extend now going to use the new clone functionality or do we need to port it?

Context:

nolanlawson commented 9 years ago

We should probably export it in the extras API. I'm becoming more and more skeptical of hyper-modularity.

Our extend() is very tailored to our particular needs, though, so it might not exactly meet Hoodie's. E.g. we convert dates to strings, and we don't support IE <=9.

NickColley commented 9 years ago

I'm going to close this out since it's pre-optimizing. Thanks for your time @nolanlawson :dancer: :+1: