Refactor connection logic - Githubissues

hookdeck / hookdeck-cli

Alternative to ngrok for localhost asynchronous web development (e.g. webhooks). No account required.

https://hookdeck.com?ref=github-hookdeck-cli

Apache License 2.0

276 stars 9 forks source link

Refactor connection logic #28

Closed leetrout closed 2 years ago

leetrout commented 2 years ago

This PR addresses the CLI synchronization issues by making several changes:

websocket.Client.Run no longer retries connections
- If a connection is not established the new Client.ConnectionLost method is called to notify the expiration channel
websocket.Client.Config no longer supports ReconnectInterval
proxy.Proxy.Run now supports retrying connections indefinitely
- Indefinite retries are subject to exponential backoff up to 10 seconds

Additionally I have:

Updated the spinner to explicitly stop and start a new instance on reconnect to fix an intermittent display bug
Refactored proxy.Proxy.createSession
- Removed unnecessary goroutine
- Always return as errors are checked
Added additional comments

Closes #23