Closed marvinroger closed 1 year ago
Hey @marvinroger, thanks for opening those PRs and sorry for the late reply. Seemingly my notifications aren't working for this repo.
I've merged and published go-npm-next@1.0.6 see: https://github.com/hookdeck/go-npm/pull/1
Updated the lockfile
Merging & creating a new 0.6.6 release. Merci beaucoup!
FYI @marvinroger I needed to add back the postinstall script in https://github.com/hookdeck/hookdeck-cli/commit/9f8e596b58c99039e65a3b8ec795bba006f16eff otherwise NPM was throwing
npm ERR! code 127
npm ERR! path /Users/alexbouchard/.nvm/versions/node/v16.13.1/lib/node_modules/hookdeck-cli
npm ERR! command failed
npm ERR! command sh -c go-npm install
This makes since on preinstall go-npm isn't installed yet.
v0.6.7 is now available with your changes!
It's only been 3 days, it's totally fine 😉 Thanks for your reactivity in releasing the fixes, I can confirm it works great now.
Avec plaisir !
This is a follow-up of https://github.com/hookdeck/go-npm/pull/1, closes #44
This PR does two things:
bin
field required for cross packages managers compatibility (and needed after thego-npm-next
update)files
property to avoid shipping all the repo files to npm (right now, the package is 3.15 MB - this should drastically reduce the package size)Checklist before being able to merge this:
go-npm-next
is updated on npmhookdeck-cli
0.6.6 release should be done, in order to bump thepackage.json
and to publish the update to npm