hookdeck / hookdeck-cli

Alternative to ngrok for localhost asynchronous web development (e.g. webhooks). No account required.
https://hookdeck.com?ref=github-hookdeck-cli
Apache License 2.0
276 stars 9 forks source link

Add support for all package managers and shrink package size #45

Closed marvinroger closed 1 year ago

marvinroger commented 1 year ago

This is a follow-up of https://github.com/hookdeck/go-npm/pull/1, closes #44

This PR does two things:

  1. It adds the bin field required for cross packages managers compatibility (and needed after the go-npm-next update)
  2. It adds an empty files property to avoid shipping all the repo files to npm (right now, the package is 3.15 MB - this should drastically reduce the package size)

Checklist before being able to merge this:

alexbouchardd commented 1 year ago

Hey @marvinroger, thanks for opening those PRs and sorry for the late reply. Seemingly my notifications aren't working for this repo.

I've merged and published go-npm-next@1.0.6 see: https://github.com/hookdeck/go-npm/pull/1

alexbouchardd commented 1 year ago

Updated the lockfile

alexbouchardd commented 1 year ago

Merging & creating a new 0.6.6 release. Merci beaucoup!

alexbouchardd commented 1 year ago

FYI @marvinroger I needed to add back the postinstall script in https://github.com/hookdeck/hookdeck-cli/commit/9f8e596b58c99039e65a3b8ec795bba006f16eff otherwise NPM was throwing

npm ERR! code 127
npm ERR! path /Users/alexbouchard/.nvm/versions/node/v16.13.1/lib/node_modules/hookdeck-cli
npm ERR! command failed
npm ERR! command sh -c go-npm install

This makes since on preinstall go-npm isn't installed yet.

v0.6.7 is now available with your changes!

marvinroger commented 1 year ago

It's only been 3 days, it's totally fine 😉 Thanks for your reactivity in releasing the fixes, I can confirm it works great now.

Avec plaisir !