search

hookdeck / hookdeck-cli

Alternative to ngrok for localhost asynchronous web development (e.g. webhooks). No account required.
https://hookdeck.com?ref=github-hookdeck-cli
Apache License 2.0
278 stars 9 forks source link

fix: Check if connection has a name before comparing with connection query #83

Closed alexluong closed 5 months ago

alexluong commented 5 months ago

When we run hookdeck listen 1234 source-name connection-name, if the source has a connection without a name, it may run into nil pointer issue. This PR will check to make sure the pointer exists first before dereference it.

alexluong commented 5 months ago

@leggetter @alexbouchardd do we need to increment the package.json version on every PR?

https://github.com/hookdeck/hookdeck-cli/actions/runs/9369372921/job/25793802510

CleanShot 2024-06-04 at 21 57 33

alexbouchardd commented 5 months ago

@leggetter The action seems to be running for every branch?

leggetter commented 5 months ago

@leggetter The action seems to be running for every branch?

The release GitHub workflow should only trigger when new tags are pushed: https://github.com/hookdeck/hookdeck-cli/blob/main/.github/workflows/release.yml#L3-L6

The test workflow should run when there's a PR to main https://github.com/hookdeck/hookdeck-cli/blob/connection-name/.github/workflows/test.yml#L3-L6

Following semver, the next released version should be v0.10.1 if this is a patch fix..