search

hookdeck / hookdeck-cli

Alternative to ngrok for localhost asynchronous web development (e.g. webhooks). No account required.
https://hookdeck.com?ref=github-hookdeck-cli
Apache License 2.0
260 stars 9 forks source link

Feat: add `--cli-path` flag support #90

Closed leggetter closed 1 month ago

alexluong commented 1 month ago

I'm thinking, as we may make changes to the destination on Hookdeck if the CLI path doesn't match, I wonder if we should communicate it to the user more clearly to avoid unintended behavior.

I'm taking inspiration from Terraform, so we can have something along the line of:

$ hookdeck listen 3000 my_source --cli-path /new/path

Source "my_source" has a connection to "my_cli_destination" with a CLI path of "/old/path". Would you like to update it on Hookdeck? ...yes/no

This way, it's a bit interactive and we can avoid making changes that the users don't expect. To skip the interactivity part, we can do --auto-approve or something like that to make it more straightforward.

What do you think? I could be overthinking a behavior that doesn't warrant this level of caution?

cc @mkherlakian

leggetter commented 1 month ago

Superseded by https://github.com/hookdeck/hookdeck-cli/pull/92