search

hookflash / obsolete.opjs-demo

Open Peer JavaScript Demo
http://webrtc.hookflash.me/
14 stars 7 forks source link

See connected contacts from multiple accounts when logged in with 1 account #8

Open elagerway opened 11 years ago

elagerway commented 11 years ago

Seeing all of my contacts on left even though I am only signed in with twitter. I did sign in with all contacts at one point but then logged off, closed browser. Opened browser and the contacts on right were correct = twitter but contacts on left showed all my demo connections, is this by design or an error? screen shot 2013-06-14 at 11 28 33 am

cadorn commented 11 years ago

By design. The left shows all contacts that have a peerContact ID set (i.e. have used demo) and you have fetched the contacts for the social network at least once (logged in).

The idea is that when you come back later or on another device you just need to log into one network and you get all your peer contacts. So the login page gives you a list of networks you can use to log in to the demo but you only need to use one. If you want to invite a user from a network you may need to log into that network (if not used for original login) before contacts will show on panel on the right.

The contacts on the left currently show duplicates. @xxllexx is fixing that. Once this is fixed and the logic I just explained is correct we can close this issue.

elagerway commented 11 years ago

This is a bit confusing from a UX and invite perspective. Needs more thought.

It could be that we need a separate invite button that allows users to invite others from networks not currently logged into, eg. prompt them for social network credentials when sending invites to users on networks which they are not currently logged into atm?

cadorn commented 11 years ago

If they are not logged in, invite contacts will not show on right.

Maybe put login buttons for other social networks that you are not logged into at the top of the invite panel instead of the top of the page?

I think we also need to be able to collapse the contacts in the invite panel by clicking on the network headings.