fix(login) context and rules for invited user consistency with IDPs

hoophq / hoop

Hoop.dev is an open-source access gateway that provides secure, seamless, and audited access to databases and infrastructure without exposing credentials or sensitive data.

https://hoop.dev

MIT License

231 stars 8 forks source link

fix(login) context and rules for invited user consistency with IDPs #509

Closed mtmr0x closed 4 weeks ago

mtmr0x commented 4 weeks ago

This PR applies some adjustments for the login flow as explained the bullet points below:

when creating the context, we first get the user by email for when the user is not yet synced with the IDP, then the context is created as before, but covering that invitation process
remove inforcement on user having to be active when first logging in, this is an old behavior and is not required anymore
change place we get the user groups to sync in the database to be consistent with the new context adjustment documented in the first item
sync the user subject with the idp always
sync the email verified field from a user with the IDP
update user status properly when the user is invited

sentry-io[bot] commented 4 weeks ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ runtime.errorString: runtime error: invalid memory address or nil pointer dereference github.com/hoophq/hoop/gateway/api/login in (*h... View Issue
‼️ runtime.errorString: runtime error: invalid memory address or nil pointer dereference github.com/hoophq/hoop/gateway/api/login in syn... View Issue

_{Did you find this useful? React with a 👍 or 👎}