Feature Request: Tab Completion - Githubissues

hoosierhobbyist / quantum-shell

An experimental terminal emulator for the Atom text editor

MIT License

19 stars 6 forks source link

Feature Request: Tab Completion #7

Closed hxegon closed 9 years ago

hxegon commented 9 years ago

Would really appreciate proper (case-insensitive) tab completion, as it is an extremely useful feature in my opinion.

hoosierhobbyist commented 9 years ago

Could you point to an explicit example of what you mean? I apologize, but I'm not very familiar.

hoosierhobbyist commented 9 years ago

All right, I did a little research on wikipedia, and I believe this is doable. Could you tell me:

Is this definitely what you meant?
If it is would you prefer the prompting completion or rotating completion?
Do you want to take a crack at it or should I?

Personally I'm leaning towards rotating completion, as I believe it would be a little easier to implement, but if there's a compelling reason, I'd be willing to try prompting.

hxegon commented 9 years ago

Sorry about the late response, that is exactly what I mean. Thanks for the quick response!

hoosierhobbyist commented 9 years ago

Very well, I will do my best to make this a part of the next release. Although, that may be a few weeks, I am currently busy with several other things. Thank you for the suggestion :smile:

hxegon commented 9 years ago

Thanks for making this. looking forward to the next release.

On Sat, Apr 4, 2015 at 7:27 PM Seth David Bullock notifications@github.com wrote:

Very well, I will do my best to make this a part of the next release. Although, that may be a few weeks, I am currently busy with several other things. Thank you for the suggestion [image: :smile:]

— Reply to this email directly or view it on GitHub https://github.com/sedabull/quantum-shell/issues/7#issuecomment-89706713 .

hoosierhobbyist commented 9 years ago

@clebrun, I had some extra time tonight, so I decided to go ahead and tackle this. It was actually surprisingly easy to implement, which has me a little-bit worried :worried:. Despite that however, I have published a new version I would greatly appreciate any feedback you might have.

hxegon commented 9 years ago

alright, I'll check it out and get back to you. Thanks for the quick implementation!

On Tue, Apr 7, 2015 at 9:01 PM Seth David Bullock notifications@github.com wrote:

@clebrun https://github.com/clebrun, I had some extra time tonight, so I decided to go ahead and tackle this. It was actually surprisingly easy to implement, which has me a little-bit worried [image: :worried:]. Despite that however, I have published a new version I would greatly appreciate any feedback you might have.

— Reply to this email directly or view it on GitHub https://github.com/sedabull/quantum-shell/issues/7#issuecomment-90796836 .

hoosierhobbyist commented 9 years ago

Update: I discovered a bug that would cause the file name completion to act a little funky, but short story short: I fixed it and released a patch. Other than that though, I believe this feature is behaving as expected, so I am going to go ahead and close this issue. Please let me know if you discover any bugs or have any other feature requests. I truly appreciate you reaching out to me :smiley: