hootlex / laravel-friendships

This package gives Eloquent models the ability to manage their friendships.
MIT License
705 stars 150 forks source link

Support for Laravel 5.8 #129

Open kainxspirits opened 5 years ago

kainxspirits commented 5 years ago

Already made a PR on MoeCasts fork, but it might be quicker to just make a new PR here.

You can delete this PR if another fix is merged.

Next version should probably be 1.1, since we drop support for previous php version.

c-fitzmaurice commented 5 years ago

I can confirm this PR fixes the event fire error.

Laroghar commented 5 years ago

I got the same issue while trying to upgrade to Laravel 5.8 and the PR fix it. Will it be available soon?

tobz-nz commented 5 years ago

Approved but not merged....? Would be great to get this merged in & released.

c-fitzmaurice commented 5 years ago

Any movement on this @hootlex? Thanks!

Laroghar commented 5 years ago

Some news about the pull request?

ianmcqueen commented 5 years ago

@hootlex hoping for a merge for Laravel 5.8 support!

tquiroga commented 5 years ago

Is the repo still maintained? Did someone else take over?

tobz-nz commented 5 years ago

@kainxspirits - might as well update this PR to add Laravel 6.0 support as well ;)

gumeniukpavel commented 5 years ago

@hootlex Please fill in these edits to support new versions of laravel