search

hootlex / laravel-moderation

A simple Content Moderation System for Laravel 5.* that allows you to Approve or Reject resources like posts, comments, users, etc.
MIT License
527 stars 68 forks source link

Scopes don't work as expected in relations #23

Open mallchin opened 7 years ago

mallchin commented 7 years ago

When strict mode is off rejected items are excluded by default through a global scope on the boot method. This is to be expected, however, it doesn't appear possible to include them using the withRejected() local scope.

$user->persona->withRejected()->first(); returns null if persona is rejected as the global scope supersedes the local one; the where status != 2 clause excludes rejected records despite the local scope where status in (1,2) including them.

hootlex commented 7 years ago

Hey,

Thanks for reporting this issue. Could you please open a pr with a failing test? That would be very useful.

mallchin commented 7 years ago

Sure, will do.