hootnot / oanda-api-v20

OANDA REST-V20 API wrapper. Easy access to OANDA's REST v20 API with oandapyV20 package. Checkout the Jupyter notebooks!
MIT License
398 stars 107 forks source link

Trades or Orders count larger than 500 #166

Closed Zouuup closed 4 years ago

Zouuup commented 4 years ago

Hi!

Thanks for the efforts,

What will happen if I have more than 500 trades or orders?

ps: Oanda base API has a limit of default 50 and max of 500.

hootnot commented 4 years ago

Pls check the OANDA docs. for an answer to that kind of question.

Zouuup commented 4 years ago

Hi @hootnot !

Thanks for the prompt reply, Oanda API doc suggest to use a "count" parameter which (as far as I can see) is not implemented on the wrapper, any ideas?

hootnot commented 4 years ago

Everything is supported! Pls have a look at the documentation. All API-endpoint request classes are setup this way:

The count parameter you refer to is probably one to be sent as:

     params = {
         "count": 500
     }
     somerequestclass(..., params=params)

The README contains examples, the jupyter noterbooks show examples and the oandapyv2-examples repo shows lots of examples pointing out how to deal with data, params and required parameters

Zouuup commented 4 years ago

Thanks!