Refact definitions - Githubissues

hootnot / oanda-api-v20

OANDA REST-V20 API wrapper. Easy access to OANDA's REST v20 API with oandapyV20 package. Checkout the Jupyter notebooks!

MIT License

403 stars 107 forks source link

Refact definitions #37

Closed hootnot closed 7 years ago

hootnot commented 7 years ago

Endpoint related definitions are stored in a dict under /definitions

This PR will :

move all the definitions to oandapyV20/definitions
dynamically generate classes from the definitions
provide the documentation
add tests

The new structure will allow us to write:

>>> import oandapyV20.definitions.orders as orderdefs
>>> print orderdefs.OrderType.MARKET
MARKET
>>> c = orderdefs.OrderType()
>>> print c['MARKET']
A Market Order

coveralls commented 7 years ago

Coverage increased (+0.03%) to 99.203% when pulling 4078b15229bd1a634cda33bd58e360f877e28de2 on refact-definitions into 6a793590cfd69d55c7d5c23a1dc41c7f5596c551 on master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 99.203% when pulling 4078b15229bd1a634cda33bd58e360f877e28de2 on refact-definitions into 6a793590cfd69d55c7d5c23a1dc41c7f5596c551 on master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 99.203% when pulling 4078b15229bd1a634cda33bd58e360f877e28de2 on refact-definitions into 6a793590cfd69d55c7d5c23a1dc41c7f5596c551 on master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 99.223% when pulling 9c31766803e09f05ff274d049d839eef33150200 on refact-definitions into 6a793590cfd69d55c7d5c23a1dc41c7f5596c551 on master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 99.225% when pulling 621ec69bf223e84011a3921e649ec5260b7acc12 on refact-definitions into 6a793590cfd69d55c7d5c23a1dc41c7f5596c551 on master.