search

hootnot / oanda-api-v20

OANDA REST-V20 API wrapper. Easy access to OANDA's REST v20 API with oandapyV20 package. Checkout the Jupyter notebooks!
MIT License
403 stars 107 forks source link

trades.TradesList missing setting params attribute #69

Closed mirac7 closed 7 years ago

mirac7 commented 7 years ago

I believe there is a bug in trades.TradesList endpoint, in __init__ method:

class TradesList(Trades):
    def __init__(self, accountID, params=None):
        super(TradesList, self).__init__(accountID)
        self.params = params  # this line is missing
hootnot commented 7 years ago

@mirac7 Yup! you are right.

The default request without parameters will work. But requests involving parameters will behave like the default requests.

Will you create the PR ?

mirac7 commented 7 years ago

Created pull request

hootnot commented 7 years ago

Thx!