search

hootsuite / nachos

Material Chips for Android
Other
451 stars 87 forks source link

White color is being ignored #48

Closed mokkun closed 6 years ago

mokkun commented 6 years ago

Summary

0xFF will equal to -1 (signed decimal), which will cause the condition chipTextColor != -1 to be false when using the white color for text. Set the default text color to transparent and compare against it to avoid the issue.

This should fix #36.

Test Plan

No specific tests are required.

simon-tse-hs commented 6 years ago

Thank you @mokkun I'll try to put in a patch release for this