hootsuite / nachos

Material Chips for Android
Other
451 stars 87 forks source link

Adding stroke lines for chips #78

Open jeanpaulpacheco opened 5 years ago

jeanpaulpacheco commented 5 years ago

Would it be possible to implement the option to add chip borders in the form of stroke? Looking at Material Design, we are given two types of chips samples:

Because of this, I'm proposing the addition of 2 new properties - chipStrokeWidth and chipStrokeColor

I have tried this locally and it does not it's not a big change to implement this, so I could push a branch and PR for this as well, but I wanted some input on the matter beforehand.

jeanpaulpacheco commented 5 years ago

I have the implementation in a fork - https://github.com/jeanpaulpacheco/nachos/commit/2ef6edd95ea2eb18407c944b91cbd30c7de2f47b