search

hop-protocol / contracts

🐰 Hop Protocol v1 smart contracts
https://hop.exchange
239 stars 83 forks source link

Add WithdrawalBonded event for bondWithdrawalAndDistribute #41

Closed miguelmota closed 3 years ago

miguelmota commented 3 years ago

The WithdrawalBonded event exists for bondWithdrawal but not for bondWithdrawalAndDistribute.

shanefontaine commented 3 years ago

I like it. Seems good from a gas perspective, as its on L2.

Only thought is that we should maybe make it a standalone event, WithdrawalBondedAndDistributed. Any thoughts @cwhinfrey?

cwhinfrey commented 3 years ago

@miguelmota Would it be acceptable to have only transferId and amount as the WithdrawalBonded event params?

If recipient, transferNonce, or bonderFee are being used, they'd have to be looked up elsewhere.

miguelmota commented 3 years ago

@cwhinfrey the other the parameters aren't used so that should be fine

cwhinfrey commented 3 years ago

@miguelmota pushed a commit to this branch. Feel free to merge if it looks good.

miguelmota commented 3 years ago

👍