hop-protocol / contracts

🐰 Hop Protocol v1 smart contracts
https://hop.exchange
239 stars 83 forks source link

fix: align ISwap interface to Swap implementation #95

Closed charlesndalton closed 2 years ago

miguelmota commented 2 years ago

@red-impala check out the v1 branch which is the current live implementation

https://github.com/hop-protocol/contracts/blob/8cefc3975115b6e3e706dd110670badad954a3bd/contracts/saddle/Swap.sol#L317

@cwhinfrey @shanefontaine wondering if we should default to v1 since it may be confusing

edit: was looking at the wrong file but the PR is still valid I think for v1 branch

charlesndalton commented 2 years ago

@miguelmota Ok, will create the PR on v1 since I see it has the same problem

charlesndalton commented 2 years ago

PR