search

hop-protocol / hop

🐰 Hop Protocol Monorepo
https://hop.exchange/
MIT License
2.85k stars 188 forks source link

mirgate frontend framework from react to nextjs. #442

Closed zhyd1997 closed 2 years ago

zhyd1997 commented 2 years ago

Nextjs v12 has big improvements and there's no need set heap size: --max_old_space_size=4096.

miguelmota commented 2 years ago

One of the requirements for the frontend is to have it easily be hosted on IPFS. I believe nextjs requires a server side piece so it's not ideal

zhyd1997 commented 2 years ago

@miguelmota

Do you mean this? https://github.com/ipfs-examples/js-ipfs-examples/tree/master/examples/browser-nextjs

or using Fleek?

Okay, I found it: https://github.com/hop-protocol/hop/blob/c547dcc23861fca5cf0151daed7610ffc7ad89ad/packages/frontend/package.json#L67

I have no experience with it.

miguelmota commented 2 years ago

Nice find, those solutions may work. We want keep the build system in github actions for transparency reasons and I don't think it's trivial to port to nextjs (could be wrong here) but we'd be happy to review/accept any pull requests with the changes

zhyd1997 commented 2 years ago

@miguelmota

I will have a try!

miguelmota commented 2 years ago

Closing issue due to no activity