Closed miguelmota closed 9 months ago
netlify[bot]
commented
9 months ago | Name | Link |
|---|---|
| Latest commit | ea8e7757bdfa5bf54641d4bf02fc16bd30f0fbce |
| Latest deploy log | https://app.netlify.com/sites/hop-sdk-docs/deploys/65d2f825f80afa00087a1a2d |
miguelmota
commented
9 months ago Closing draft PR.
Reasons / issues I ran into:
abitype to implement a typed ethers Contract for dynamic abis became overly complex and requires in-depth knowledge of ethers Contracts and everything it extends, so would require a lot more effort and research.@wagmi/core has support for typed contracts for ethers@5 using abitype, however some things were missing in it's type implementation which broke builds.viem has support for abitype for ethers Contract, however it only works with ethers@6. Possible solution:
Ricmoo from ethers mentioned two weeks in an issue thread he's working on a version of Contracts based on abitype. Given that, I think it makes sense to try to upgrade to ethers@6 at some point and use the typed Contract class when it's ready if the plan is to stick with ethers long term. Migrating to viem could also be a good alternative. Of course neither solution is trivial so would require more thought. In the meantime, sticking with typechain and ethers@5 shouldn't be an issue.
✅ Deploy Preview for hop-explorer-goerli ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.