search

hope366 / Lizzie-improvements

Lizzie - Leela Zero Interface
GNU General Public License v3.0
29 stars 9 forks source link

Update DisplayStrings_ko.properties #4

Closed wonsiks closed 3 years ago

hope366 commented 3 years ago

Hi, @wonsiks san. Thank you for posting the pull request. It seems to be a correction about Korean notation, so java -jar -Duser.language=Korean lizzie-improved-v1.9.jar I tried. Even though I specified Korean, the UI is displayed in English. This is the same before and after applying the PR. I have little knowledge of programming, so I'm not sure. Can you tell us the nature of this PR?

wonsiks commented 3 years ago

@hope366 Yes, it's for Korean notation. I guess you can see only in Japanese and English because of OS language. I also can see in Korean and English even when I start lizzie with Japanese option. Actually this pull request is not translated by myself but other Korean user translated. This pull request will help Korean people to see better translated lizzie. 20201209_084507 20201209_084544 20201209_084606

hope366 commented 3 years ago

Thank you for pasting the screenshot and explaining it in an easy-to-understand manner. Unfortunately I can't read Korean so I can't understand what the screenshots are. Also, the content of the PR is like a cipher, so I don't know what kind of modification was made. Has the operability improved considerably after actually using lizzie? If so, I would like to incorporate the idea into the Japanese version.