search

hopinc / cli

💻 Interact with Hop in your terminal
https://docs.hop.io/cli
Mozilla Public License 2.0
78 stars 8 forks source link

chore: clippy fixes #14

Closed knvi closed 1 year ago

knvi commented 1 year ago

hey,

made some small changes to the code to get rid of most of the clippy errors (ran clippy with clippy::pedantic, all, cargo, nursery). builds just fine.

cheers

TheLDB commented 1 year ago

lgtm. kunevi 100x dev, best dev.

hire him while you're at it

iKeaton commented 1 year ago

LGTM!

alsonick commented 1 year ago

Lgtm!! 👍

alii commented 1 year ago

LGTV image

pxseu commented 1 year ago

hi, clippy pedantic is the highest lint level and im not getting any of the lints you got except clippy cargo which are different. everything is always linted with cargo +nightly clippy running bleading edge version if dependencies allow or stable. could you elaborate how you got to this?

knvi commented 1 year ago

I added 

#![warn(
clippy::all,
clippy::pedantic,
clippy::nursery,
clippy::cargo
)]

to the beginning of the lib.rs file. I'm running stable toolchain, perhaps that's why. Even if not for the clippy lints, then those are general code improvements

pxseu commented 1 year ago

oh yeah no doubt in that, just was wondering since i haven't seen these get flagged before