search

hoplon / boot-hoplon

Boot task to build Hoplon web applications.
Eclipse Public License 1.0
8 stars 5 forks source link

Provide method of selecting between jquery and gcl #5

Closed burn2delete closed 8 years ago

burn2delete commented 8 years ago

This PR allows building future versions of hoplon while continuing to provide a similar developer experience.

Without the developer changing anything boot-hoplon will now auto include hoplon.jquery in page declaration. (requires cljsjs/jquery in dependencies) included with hoplon

If a set of symbols is passed to :require, the above behaviour is negated.

Additionally :jquery and :goog boolean options are provided, which allows users to select an attribute provider. The respective namespace will be added to :require, does not however manage dependencies. (:goog still requires the developer to include hoplon/brew in dependencies)

REQUIRES: hoplon/hoplon#140

burn2delete commented 8 years ago

We can deprecate hoplon.jquery for hoplon.goog once it gets in core we then lose the jquery dependency at that point.

When deprecating, we should remove the auto include of hoplon.jquery dev's should either make a selection on the hoplon task or include the ns manually in the page declaration.

See line 73 for reference.