hoplon / castra

HTTP remote procedure call handler for Clojure.
172 stars 25 forks source link

Rename defn to defprc #2

Closed devn closed 10 years ago

devn commented 10 years ago

Thoughts?

alandipert commented 10 years ago

Into it.

micha commented 10 years ago

I'd prefer to add defrpc but also keep defn (possibly adding ^:deprecated metadata to it) so as not to break any existing apps, but if you feel strongly about it I don't object. I'm just a little apprehensive about making breaking changes when we have so little useful documentation. It seems like it could cause hassles for people.

In user code they could then have the choice to do either

(ns my-ns
  (:refer-clojure :exclude [defn])
  (:require [tailrecursion.castra :refer [defn]]))

or

(ns my.ns
  (:require [tailrecursion.castra :refer [defrpc]]))

as they prefer.

mynomoto commented 10 years ago

I agree with @micha, ^:deprecated is a better way for users. But the sooner we add defrpc the better.