search

hoplon / javelin

Spreadsheet-like dataflow programming in ClojureScript.
803 stars 44 forks source link

Unquote c on set-cell!=, use clojure.core/destructure #33

Closed mynomoto closed 7 years ago

mynomoto commented 7 years ago

Fixes #32

The unrelated change of destructure is because cljs.core/destructure is pretty recent and don't work on older versions of clojurescript.

micha commented 7 years ago

@mynomoto I also thought the cljs.core/destructure was a typo, but I think it's correct. I think we just need to require the cljs.core namespace: https://github.com/hoplon/javelin/pull/31/commits/6b634795ef2225be848491d9279e742863d6aba6

micha commented 7 years ago

I guess we could do something like (if (resolve 'cljs.core/destructure) ... perhaps

mynomoto commented 7 years ago

I think you are right, destructure is from at least april of 2015. Should be safe enough.

micha commented 7 years ago

I rolled this into #31 :man_singer: