hopperelec / RandomEventsPlugin

A Spigot/PaperMC plugin that causes random events to occur in the world and block/entity drops to be randomised
Creative Commons Attribution Share Alike 4.0 International
1 stars 0 forks source link

RandomEventsGame::learn ConcurrentModificationException when resetting lore #35

Open hopperelec opened 1 year ago

hopperelec commented 1 year ago

RandomEventsGame::learn iterates through itemsWithLore.get(seed) but also RandomEventsGame::resetLoreFor >RandomEventsGame::removeLoreFor which removes items from itemsWithLore

hopperelec commented 1 year ago

I think I'd like to fix this by giving RandomEventsGame::resetLoreFor custom functionality, because lots of code from removeLoreFrom and addLoreTo are redundant when used at the same time and lead to issues like this

hopperelec commented 1 year ago

Why is handling lore such a pain..?