Closed gbmor closed 2 years ago
Possibly we'll need to remove the stuffbin deps since go 16x introduced the same functionality in the stdlib. Will push an update as soon as possible.
A lot of stuff needs to be fixed 😅 . Will push some of the patches in time
@gbmor this is good to merge right? I'm planning to merge this as soon as I get a response
@athul added conditional to only install stuffbin if it's not already installed on 'make' or 'make deps' or 'make all', merged hopp-cli/master
back into my branch, looks okay
All of these changes are related to either dependency updates, the go version update
1.13 -> 1.16
, or the Makefile (and some of the Makefile changes are related to the go version update).Updated the dependencies since they were several versions behind.
Makefile
was no longer functioning as intended. The default target had been changed todeps
, so it would installstuffbin
and exit. I addedall
as the default target to call bothdeps
andbuild
, and fixed the build line inbuild
(it wasn't building anything). I also fixed thedeps
target to installstuffbin
without manglinggo.mod
(go
now lets you usego install url/to/repo@latest
to do this). Then cleaned up the remaining targets, so theMakefile
is working 100% again.go.mod
still referred to the old repository, so I updated it to have the new path atgithub.com/hoppscotch/hopp-cli
and bumped the minimum go version to1.16
.Note: The install script linked in
README.md
still referencespwcli
so it needs to be updated, but it doesn't live in this repo so I can't update it.Removed references to deprecated standard library package
ioutil
in favor ofio.ReadAll
andos.ReadFile
.Replaced string interpolation with wrapping when bubbling up errors with additional context.