hoppscotch / hopp-cli

🤖 HTTP CLI client for https://hoppscotch.io
https://hoppscotch.io
MIT License
176 stars 24 forks source link

Dependencies, go version update, and Makefile fixes #44

Closed gbmor closed 2 years ago

gbmor commented 2 years ago

All of these changes are related to either dependency updates, the go version update 1.13 -> 1.16, or the Makefile (and some of the Makefile changes are related to the go version update).

Updated the dependencies since they were several versions behind.

Makefile was no longer functioning as intended. The default target had been changed to deps, so it would install stuffbin and exit. I added all as the default target to call both deps and build, and fixed the build line in build (it wasn't building anything). I also fixed the deps target to install stuffbin without mangling go.mod (go now lets you use go install url/to/repo@latest to do this). Then cleaned up the remaining targets, so the Makefile is working 100% again.

go.mod still referred to the old repository, so I updated it to have the new path at github.com/hoppscotch/hopp-cli and bumped the minimum go version to 1.16.

Note: The install script linked in README.md still references pwcli so it needs to be updated, but it doesn't live in this repo so I can't update it.

Removed references to deprecated standard library package ioutil in favor of io.ReadAll and os.ReadFile.

Replaced string interpolation with wrapping when bubbling up errors with additional context.

athul commented 2 years ago

Possibly we'll need to remove the stuffbin deps since go 16x introduced the same functionality in the stdlib. Will push an update as soon as possible.

athul commented 2 years ago

A lot of stuff needs to be fixed 😅 . Will push some of the patches in time

athul commented 2 years ago

@gbmor this is good to merge right? I'm planning to merge this as soon as I get a response

gbmor commented 2 years ago

@athul added conditional to only install stuffbin if it's not already installed on 'make' or 'make deps' or 'make all', merged hopp-cli/master back into my branch, looks okay