search

hoppscotch / hoppscotch-extension

🧩 Browser extensions to provide more capabilities to https://hoppscotch.io
https://hoppscotch.io
MIT License
254 stars 95 forks source link

[bug]: Chrome extension loses origin list after Chrome restart or backend upgrade #269

Closed tomerr-ma closed 3 months ago

tomerr-ma commented 8 months ago

We have noticed that sometimes (seems to be correlated with version upgrades of the hoppscotch backend version), we lost the Hoppscotch URL in the Chrome extension.

tomerr-ma commented 7 months ago

We Also see it happens also in Chrome restart and not necessarily when upgrading version which is more severe. happens also on version 0.31

tomerr-ma commented 7 months ago

@liyasthomas @AndrewBastin the bug seems to be triggered when Chrome version update occurs.

Seems like chrome.runtime.onInstalled.addListener(() in src/index.js, Line:358 is using this function which according to the docs is "Fired when the extension is first installed, when the extension is updated to a new version, and when Chrome is updated to a new version."

Looks likes the origin list is being overwritten with default origin list on every Chrome Browser update.

image

SanskritiHarmukh commented 7 months ago

@liyasthomas @AndrewBastin the bug seems to be triggered when Chrome version update occurs.

Seems like chrome.runtime.onInstalled.addListener(() in src/index.js, Line:358 is using this function which according to the docs is "Fired when the extension is first installed, when the extension is updated to a new version, and when Chrome is updated to a new version."

Looks likes the origin list is being overwritten with default origin list on every Chrome Browser update.

image

Hi @tomerr-ma we'll try to reproduce the issue again and revert back to you. Thanks for the update.

amk-dev commented 3 months ago

closing as the PR #282 is merged.