hoprnet / hopr-core

Main repository of HOPR - this is all you need to run a node on the HOPR network!
https://hoprnet.org
GNU General Public License v3.0
14 stars 5 forks source link

Required default connectors/dependencies are not included/exposed inside npm package #145

Closed 0xjjpa closed 4 years ago

0xjjpa commented 4 years ago

Introduction

When trying to instantiate hopr-core, a hopr-connector is required as an option to get started. For the time being, hopr-core-ethereum is the default connector for using hopr-core. Right now, one needs to add hopr-core-ethereum manually to the package using hopr-core, which one could argue should be inside hopr-core as otherwise it's not possible to run hopr-core.

Task Description

Definition of Complete

The task is completed when hopr-core does not require any other @hoprnet library to get started on its own.

Testing criteria

Notes

Right now chat and server look as follows in terms of package dependencies.

@hoprnet/hopr-core
    "@hoprnet/hopr-core-connector-interface": "1.3.1-refactor.76c9b25",
    "@hoprnet/hopr-core-ethereum": "0.0.12-refactor.473415f",
    "@hoprnet/hopr-demo-seeds": "1.0.3-refactor.3ad82ff",
    "@hoprnet/hopr-utils": "0.1.6-refactor.61df948",
@hoprnet/hopr-chat
    "@hoprnet/hopr-core": "0.6.16",
    "@hoprnet/hopr-core-connector-interface": "1.2.10-98e08f8",
    "@hoprnet/hopr-core-ethereum": "0.0.12-refactor.473415f",
    "@hoprnet/hopr-demo-seeds": "1.0.3-refactor.3ad82ff",
    "@hoprnet/hopr-utils": "0.1.6-refactor.61df948",

after this task, these should look as follows:

@hoprnet/hopr-core
    "@hoprnet/hopr-core-connector-interface": "1.3.1-refactor.76c9b25",
    "@hoprnet/hopr-core-ethereum": "0.0.12-refactor.473415f",
    "@hoprnet/hopr-demo-seeds": "1.0.3-refactor.3ad82ff",
    "@hoprnet/hopr-utils": "0.1.6-refactor.61df948",
@hoprnet/hopr-chat
    "@hoprnet/hopr-core": "0.6.16",
0xjjpa commented 4 years ago

Sadly this one didn't fit in our current focus and workload, moving to Sprint 10.

nionis commented 4 years ago

couldn't make @hoprnet/hopr-chat package.json look like the example above, this is because both chat and server depend on packages like @hoprnet/hopr-utils for their own use