Refactoring hopr projects - Githubissues

hoprnet / hopr-core

Main repository of HOPR - this is all you need to run a node on the HOPR network!

https://hoprnet.org

GNU General Public License v3.0

14 stars 5 forks source link

Refactoring hopr projects #198

Closed nionis closed 3 years ago

nionis commented 4 years ago

hope-core

[ ] expose pubKeyToPeerId instead of importing like this, same behaviour can be found in hopr-chat too
[ ] deprecate output 1

hopr-server

[ ] if start/stop is called while the node is already starting/stopping, it should return it's promise
[ ] setup better error handling, ideally we should be able to tell nestjs what kind of grpc error occured 1
[ ] jest e2e tests doesn't properly terminate due to open handles 1

hopr-core-ethereum

[ ] provide state in channel instance 1
[ ] open channel should return txHash 1
[ ] close channel should return txHash 1
[ ] types like Balance are not properly recognized by typescript 1
[ ] settling a channel in hopr-core-ethereum currently means that it will wait until the settlement period is over and then trigger the transaction, this might not be what we want in hopr-server

hopr-proto

[x] update protos to snake_case so it's properly converted to camelCase by protoc 1, 2, 3, 4, 5, 6
[x] rename getChannelnfo to getChannel 1
[ ] open channel should return txHash 1
[ ] close channel should return txHash 1
[x] open channel proto doesn't provide funding amount 1
[ ] send should be able to request and respond with intermediate peer ids 1
[ ] build step doesn't bundle files for web

protoc

[ ] for proto fields that are a list or map, protoc will insert ..List / ..Map suffix at the end of the field, making it incompatible with nestjs 1, 2, 3, 4; tracking issue here

nionis commented 4 years ago

addressing some of these issues in https://github.com/hoprnet/hopr-core/issues/216