hoprnet / hopr-core

Main repository of HOPR - this is all you need to run a node on the HOPR network!
https://hoprnet.org
GNU General Public License v3.0
14 stars 5 forks source link

hopr-core test suite fails #231

Closed nionis closed 4 years ago

nionis commented 4 years ago

Describe the bug tests fail at least 75% of the time

To Reproduce Steps to reproduce the behavior:

  1. Run yarn test

Expected behavior Tests should pass, if some of them are WIP they can be skipped, the end goal is to re-enable hopr-core test suite in our CI.

Additional context taken from riot:

currently when making a PR to hopr-core, we don't run any tests of hopr-core because they seem to fail at least 75% of the time (sometimes they do pass though), tests are disabled by omitting core in this line

To do

robertkiel commented 4 years ago

The problem happens because Jest is using parallel testing and the unit tests listen to specific ports instead of dynamically chosen ones.

Concurrent testing will therefore produce EADDRINUSE errors.

nionis commented 4 years ago

@robertkiel feel free to re-enable CI tests in this workflow once fixed 👍

robertkiel commented 4 years ago

Tests are working again. Needed to run them --runInBand and sequentionally through maxConcurrency: 1

peterbraden commented 4 years ago

Reenabled in #256