implement grpc proxy for hopr-server

hoprnet / hopr-core

Main repository of HOPR - this is all you need to run a node on the HOPR network!

https://hoprnet.org

GNU General Public License v3.0

14 stars 5 forks source link

implement grpc proxy for hopr-server #239

Closed nionis closed 4 years ago

nionis commented 4 years ago

gRPC-Web browser clients connect to gRPC services via a special gateway proxy, this can be done by a proxy like envoy or nginx

related issues: 1, 2

0xjjpa commented 4 years ago

Can you setup a docker-compose.yml to setup the envoy or nginx proxy to talk to the server?

0xjjpa commented 4 years ago

Already completed this in https://github.com/hoprnet/mazebot/blob/master/docker-compose.yaml, so you can reuse the proxy code there.

nionis commented 4 years ago

@jjperezaguinaga

goal:

move the envoy folder into it's own repository
include in hopr-server a docker-compose file that includes server and envoy

thoughts?

0xjjpa commented 4 years ago

@nionis The envoy part is too small to be in its own repo IMHO. Maybe we can just keep it in server, as we won't ever use it w/o server anyway. Yay or nay?

nionis commented 4 years ago

@jjperezaguinaga Yay, let's do as we discussed in the call: hopr-server dockerfile should start hopr-server and envoy managed by something like pm2 or similar

nionis commented 4 years ago

Closed by https://github.com/hoprnet/hopr-server/pull/2