hopsoft / turbo_boost-commands

Commands to help you build robust reactive applications with Rails & Hotwire.
MIT License
322 stars 20 forks source link

Ensure we always render errors with the Append strategy #134

Closed hopsoft closed 6 months ago

hopsoft commented 9 months ago

Resolves #133

TLDR;

TODOs

github-actions[bot] commented 9 months ago

AppMap runtime code review

Summary Status
Failed tests :white_check_mark: All tests passed
Security flaws :white_check_mark: None detected
Performance problems :white_check_mark: None detected
Code anti-patterns 🚨 1 new
New AppMaps :star: 56 new minitest tests
Removed AppMaps :heavy_multiplication_x: 8 removed minitest tests

Warnings occurred during analysis:

(apiDiff) Error comparing OpenAPI definitions: Validation errors in "head": Swagger schema validation failed. 
  Data does not match any schemas from 'oneOf' at #/paths//tests/get/responses/285
    Missing required property: description at #/paths//tests/get/responses/285
    Missing required property: $ref at #/paths//tests/get/responses/285

JSON_OBJECT_VALIDATION_FAILED

Code anti-patterns

🚨 New problems detected (1)

HTTP 500 status code ##### Description > HTTP 500 status code | Field | Value | | --- | --- | | Rule | [http-500](https://appmap.io/docs/analysis/rules-reference.html#http-500) | | Impact domain | Stability | ##### View in AppMap - [Full AppMap »](https://getappmap.com/github_artifact?owner=hopsoft&repo=turbo_boost-commands&run_id=9165413881&base_revision=9b4535ca0fe17481e70ae292d03db5b3e984d376&head_revision=de66581f747ca13c3b3f9f23d574fd68b84fd226&path=head%2Fminitest%2FDrivers_window_command_that_ALLOWS_the_rails_controller_action_to_perform_handles_error.appmap.json&state=eyJzZWxlY3RlZE9iamVjdCI6ImFuYWx5c2lzLWZpbmRpbmc6YzUyYzE3NWJmYTZiZTJkYmNmZTFkZTY3MmQ3ZGI3NjhmODdhM2QxMjZiNDMxNzhjNjAxYjQwODBiZTZhMjZkYSJ9)

⭐ New AppMaps

[minitest] Drivers window command that ALLOWS the rails controller action to perform handles abort from test/system/tests/drivers/window_test.rb:48

[minitest] Drivers window command that ALLOWS the rails controller action to perform handles error from test/system/tests/drivers/window_test.rb:59

[minitest] Turbo boost/commands/command validator valid? with inherited methods from test/turbo_boost/commands/command_validator_test.rb:111

[minitest] Turbo boost/commands/command validator valid? with invalid class from test/turbo_boost/commands/command_validator_test.rb:76

[minitest] Turbo boost/commands/command validator valid? with missing class from test/turbo_boost/commands/command_validator_test.rb:62

[minitest] Turbo boost/commands/command validator valid? with private methods from test/turbo_boost/commands/command_validator_test.rb:104

[minitest] Turbo boost/commands/command validator valid? with protected methods from test/turbo_boost/commands/command_validator_test.rb:97

[minitest] Turbo boost/commands/command validator valid? with public methods that accept arguments from test/turbo_boost/commands/command_validator_test.rb:135

[minitest] Turbo boost/commands/command validator valid? with public methods from test/turbo_boost/commands/command_validator_test.rb:90

[minitest] Turbo boost/commands/command validator validate with inherited methods from test/turbo_boost/commands/command_validator_test.rb:153

Because there are many new AppMaps, some of them are not listed in this report.

✖️ Removed AppMaps

[minitest] Turbo boost/commands/state fetch

[minitest] Turbo boost/commands/state new with expiration

[minitest] Turbo boost/commands/state new with size

[minitest] Turbo boost/commands/state read and write with expiration

[minitest] Turbo boost/commands/state read and write

[minitest] Turbo boost/commands/state state.now cannot have a now

[minitest] Turbo boost/commands/state to h

[minitest] Turbo boost/commands/state to sgid param and from sgid param