horihiro / esp8266-google-home-notifier

MIT License
103 stars 23 forks source link

ESP8266 Example Compile Error #40

Open pr-wiley opened 3 years ago

pr-wiley commented 3 years ago

When attempting to compile the "Simple Usage" example for 8266 using Arduino IDE vision 1.8.16 I get this compile error:

/Users/prw/Documents/Arduino/libraries/esp8266-google-home-notifier/src/ESP8266mDNS.cpp: In member function 'MDNSTxt MDNSResponder::_getServiceTxt(char, char)': /Users/prw/Documents/Arduino/libraries/esp8266-google-home-notifier/src/ESP8266mDNS.cpp:569:42: error: cannot convert 'bool' to 'MDNSTxt' in return 569 | if (servicePtr->_txts == 0) return false; | ^~~~~ exit status 1 Error compiling for board LOLIN(WEMOS) D1 mini (clone).

DanBar1971 commented 3 years ago

I got the same error.

horihiro commented 3 years ago

Sorry for the delay. I confirmed that this issue happened on ESP8266 Arduino Core@3.x .

Please downgrade ESP8266 Arduino Core to 2.7.4 and try again if this is urgent though I will fix this when I can make time.

ddebasilio commented 2 years ago

I'm also facing similar issues. I am unable to compile the latest version of the library 😢 . Any chance that this could be fixed? I am building a weather station that should talk to google, but I would prefer to work with the latest core.

wiltwong commented 2 years ago

Edit line 569 of ESP8266mDNS.cpp to return nullptr instead of false

horihiro commented 2 years ago

Because I don’t have any ESP8266/32 devices now, I cannot fix and release a new version for ESP8266 Arduino Core @ 3.x. Try the above suggestion.

# Due to the above reason, I will archive this repository.