search

horihiro / esp8266-google-home-notifier

MIT License
103 stars 23 forks source link

add dependency to platformio file #7

Closed cujomalainey closed 6 years ago

cujomalainey commented 6 years ago

This way users won't have track down the tts dependency if they are using platformio

horihiro commented 6 years ago

Thanks @cujomalainey,

I'll check your PR(, and learn about platformio).

cujomalainey commented 6 years ago

Dont forget to do a release so the change is picked up by platformio

horihiro commented 6 years ago

Thanks @cujomalainey for your comment!

I'm checking whether there is any change to be include in next release.

horihiro commented 6 years ago

I released it yesterday. Was the change picked up by platformio?

cujomalainey commented 6 years ago

Hasn't been picked up yet, sometimes it can take a few days. I think the actual arduino tracker runs weekly

cujomalainey commented 6 years ago

Hmm, there appears to be a bug in platformio, the dependency is not found in the build phase but I can copy the name and find it manually no problem. I filed an issue upstream. Here is the link.

 …/tempp  ✔  pio run
Processing e (platform: espressif32; board: featheresp32; framework: arduino)
-------------------------------------------------------------------------------------------------
LibraryManager: Installing id=5425
Downloading...
Unpacking  [####################################]  100%
Verbose mode can be enabled via `-v, --verbose` option
PLATFORM: Espressif 32 > Adafruit ESP32 Feather
SYSTEM: ESP32 240MHz 320KB RAM (4MB Flash)
DEBUG: CURRENT(esp-prog) EXTERNAL(esp-prog, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny)
Library Dependency Finder -> http://bit.ly/configure-pio-ldf
LDF MODES: FINDER(chain) COMPATIBILITY(soft)
Collected 25 compatible libraries
Scanning dependencies...
Error: Could not find `esp8266-google-tts` dependency for `esp8266-google-home-notifier` library
=================================== [ERROR] Took 1.81 seconds ===================================
 …/tempp  ↵ 1  vi platformio.ini
 …/tempp  ✔  pio lib search esp8266-google-tts
Found 1 libraries:

esp8266-google-tts
==================
#ID: 2751
generate the link to speech mp3 on esp8266/32.

Keywords: processing, data
Compatible frameworks: Arduino
Compatible platforms: Espressif 32, Espressif 8266
Authors: horihiro
horihiro commented 6 years ago

Thanks @cujomalainey If this issue is caused by this library, please let me know.

cujomalainey commented 6 years ago

@horihiro Just figured I would mention that Ivan's pull fixed the bug

 …/test  ✔  pio run
Processing e (platform: espressif32; board: featheresp32; framework: arduino)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
LibraryManager: Installing id=5425
Downloading...
Unpacking  [####################################]  100%
LibraryManager: Installing id=2751
Downloading...
Unpacking  [####################################]  100%
Verbose mode can be enabled via `-v, --verbose` option
PLATFORM: Espressif 32 > Adafruit ESP32 Feather
SYSTEM: ESP32 240MHz 320KB RAM (4MB Flash)
DEBUG: CURRENT(esp-prog) EXTERNAL(esp-prog, minimodule, olimex-arm-usb-ocd, olimex-arm-usb-ocd-h, olimex-arm-usb-tiny-h, olimex-jtag-tiny)
Library Dependency Finder -> http://bit.ly/configure-pio-ldf
LDF MODES: FINDER(chain) COMPATIBILITY(soft)
Collected 26 compatible libraries
Scanning dependencies...
Dependency Graph
|-- <esp8266-google-home-notifier> 1.0.6
|   |-- <esp8266-google-tts>
horihiro commented 6 years ago

Thanks! please let me know if I haye to do more actlon.