horilla-opensource / horilla

Horilla is a free and open source HR software.
https://www.horilla.com/
GNU Lesser General Public License v2.1
209 stars 141 forks source link

Hour Account > Minus hours calculations? > Not Approved OT Hours still shown #31

Open borishinzer opened 1 year ago

borishinzer commented 1 year ago

Is there a way to see a total summary of either overtimes or minus hours per day, week, month - and also transfer those to the next month or to reset them, in case overtimes were paid?

Also, similar to overtimes, minus hours should be reported and approved by a supervisor.

horilla-opensource commented 1 year ago

Hi @borishinzer , Currently we do not have this feature added in our system. We are planning to adding it the upcoming updates. Once done, we'll update you with it. With Regards, Team Horilla

borishinzer commented 1 year ago

Any update on this feature? IMO it would only be showing either overtimes or undertimes (minus hours) in hour account.

CybroOdooDev commented 1 year ago

Hi @borishinzer , Not presently. We have it in our queue. Sorry for the delay. With Regards, Team Horilla

borishinzer commented 1 year ago

Any update on this issue? This would be really awesome to integration as it would be our final issue (and fix for https://github.com/horilla-opensource/horilla/issues/54) to move completely to Horilla in favour of Kimai, which we used formerly.

horilla-opensource commented 1 year ago

Hi @borishinzer , We get your concern. We'll get back to you with the solution to this by the end of this week. Sorry for the delay to this.

With Regards, Team Horilla

horilla-opensource commented 1 year ago

Hi @borishinzer , We have updated the hour calculation method. Please check the commit Please refer the video for the workflow.

https://github.com/horilla-opensource/horilla/assets/131998600/e5e11082-36fe-4eed-a6f3-3a67375f445e

With Regards, Team Horilla

horilla-opensource commented 1 year ago

Hi @borishinzer , Any updates on the above solution?

With Regards, Team Horilla

borishinzer commented 11 months ago

Do I get this right? Pending hours are "minus hours" (if the employee worked too few hours in one month / period). Also, if the times are validated then they are taking into account, resulting in either overtimes or "pending hours"?

horilla-opensource commented 11 months ago

Hi @borishinzer , Yes, pending hours are considered as minus hours. If attendance with pending hours are validated, then it is considered for the monthly account. Similarly in the case of overtime. Only once approved, it'll be added to the accounts.

borishinzer commented 11 months ago

Cool. We are checking it for this for November. It would be good to show this column also to employees in the "My Attendances" .

horilla-opensource commented 11 months ago

Sure, will add that.

horilla-opensource commented 11 months ago

Hi @borishinzer , We have added the column for viewing the pending hours in My Attendances.

Screenshot 2023-12-01 at 3 56 01 PM

Please check.

With Regards, Team Horilla

borishinzer commented 11 months ago

Awesome. Checking now our time tracking for November and will update the issue here.

borishinzer commented 11 months ago

Seems last update broke the validation somehow. I try to validate various entries, but they stay for validation.

CybroOdooDev commented 11 months ago

Are you getting any kind of error notifications or is it its just not getting validated even after clicking the validate button?

borishinzer commented 11 months ago

No error, time entry stays in tab "Validate Attandance". We even get a success message. Same behaviour under Actions.

borishinzer commented 11 months ago

Tried in Firefox incognito mode - issue stays the same. Where to find the logs?

horilla-opensource commented 11 months ago

Hi @borishinzer , Sorry for the delay. We were able to reproduce the issue mentioned above from our side and we have made a fix for it.

Please check: [FIX] ATTENDANCE: Attendance validation issue

The issue was with the validation methods. There was an existing request pending for that corresponding attendance. So on validating it was causing the issue. In the new workflow user will be given a warning if there is an existing request pending prior to validation and user can view the corresponding request from that view where they will be able to approve it.

Screenshot 2023-12-02 at 2 22 09 PM

With Regards, Team Horilla

borishinzer commented 11 months ago

Still not completely fixed. I get the request and then head over to "approve" the time entry, which doesn't change anything. If I "edit" and "save" the record without changing anything, it will get automatically approved.

borishinzer commented 11 months ago

You can find a video of the issue here: https://cloud.web-vision.de/index.php/s/oN7RMiNHXP4Fz7H

borishinzer commented 11 months ago

Additional: it seems that sometime "approval" is working and sometimes not.

horilla-opensource commented 11 months ago

Sure, we'll check and update the solution asap.

horilla-opensource commented 11 months ago

Still not completely fixed. I get the request and then head over to "approve" the time entry, which doesn't change anything. If I "edit" and "save" the record without changing anything, it will get automatically approved.

Hi @borishinzer , Could you check with the latest commits for the fix?

borishinzer commented 11 months ago

We didn't validate the time calculations yet, as we needed a full month of time trackings before. Our people are now actively testing Horilla based on the time trackings for November, December. Our aim is to report bugs and improvements and start using Horilla only (as substitute for Kimai) with beginning of November.

At this point I would like to says THANK YOU for your incredible work and your fast responses. This is really awesome 🙏

horilla-opensource commented 11 months ago

Hi @borishinzer , Thanks for taking your time in testing out Horilla and providing us with your suggestions to improve our system. We are ready to assist you in all the support needed for setting up Horilla in your side. Please feel free to contact us with any queries. (info@horilla.com)

With Regards, Team Horilla

horilla-opensource commented 7 months ago

Hi @borishinzer , Any updates on the issue fix?

With Regards, Team Horilla

borishinzer commented 7 months ago

Still not working properly. I have validated all times of an employee and also approved his overtimes. Still the hour account shows wrong values and pending approvals.

Bildschirmfoto 2024-03-28 um 10 39 00
borishinzer commented 2 months ago

Any updates on this task?

horilla-opensource commented 2 months ago

Hi @borishinzer , We have made changes for the calculation methods in our previous commits. Can you confirm with the latest commits if its fixed for you ?

We apologize for not providing an update on the same.

With Regards, Team Horilla

Riiiad commented 1 month ago

Hey @horilla-opensource, Seems that the Times are still not showen correctly in the Hour Account.

Here you can see that Overtime is 0:00.

Screenshot 2024-09-26 at 10 09 56

When you go into the Day View Overtime are shown - /attendance/attendance-search?employee_id=10&attendance_validated=true&attendance_date__gte=2024-07-01&attendance_date__lte=2024-07-31

Screenshot 2024-09-26 at 10 12 14
horilla-opensource commented 1 month ago

Hi @Riiiad , Can you confirm in the overtime tab whether it is need to be approved?

In the attendance menu, you can find OT Attendances, please check whether there is any overtime pending for this employee that month.

Screenshot 2024-09-26 at 1 55 00 PM

With Regards, Team Horilla

Riiiad commented 1 month ago

I can confirm that all times are Approved:

Screenshot 2024-09-26 at 11 21 24
horilla-opensource commented 1 month ago

Hi @Riiiad , Can you please share the Attendance Break Point settings inside the Settings ?

Screenshot 2024-09-26 at 3 12 06 PM

Also can you please share the details of the Not Approved OT Hours column in the Hour Account view (marked in red in the screenshot)

Screenshot 2024-09-26 at 3 13 39 PM

In case if you don't see this column, you can enable the column by clicking in the hamburger menu dot icon (marked green in the screenshot) and enabling that column.

Riiiad commented 1 month ago

I dont undestand why there is 2 Places to approve overtimes? OT Tab and Hour Account... this is confusing UI

I dont have the option Attendance Break point dont know show to get there, also the Not Approved OT Hour is not in the options

Screenshot 2024-09-26 at 12 07 42
Riiiad commented 1 month ago

When I Confirm the Overtime in the Hour Account also it shows in the View... The problem is I have to approve everyday even if it has no overtime. Is there a Bulk option to Confirm all days or at lease a month?

horilla-opensource commented 1 month ago

Hi @Riiiad , The screenshot I have added above is from the Hour Account. From the screenshot you have added, its of the Attendance view.

The Attendance Break Point can be fetched from the Settings option.

Screenshot 2024-09-26 at 3 42 19 PM
horilla-opensource commented 1 month ago

When I Confirm the Overtime in the Hour Account also it shows in the View... The problem is I have to approve everyday even if it has no overtime. Is there a Bulk option to Confirm all days or at lease a month?

Yes, we do have an option for Bulk approval.

Screenshot 2024-09-26 at 3 45 30 PM

For Bulk Approval, select the records which you want to approve in bulk (as seen on 1 in the screenshot)

Once selected, click on the Actions tab (maked as 2 in the screenshot )

Click on Approve OT and confirm.

Riiiad commented 1 month ago

No this is the wrong view you have. I need to Confirm in the Hour Account Tab. As in the OT Tab these entries are not there.

horilla-opensource commented 1 month ago

Can I know which version of Horilla you are using or the git head?

Riiiad commented 1 month ago

I need to check the exact commit but the Date is 24.September

horilla-opensource commented 1 month ago

Then it should be having the view that I have added in the screenshot above. Please confirm with the url from the screenshot also that we are in the same menu option view.

Riiiad commented 1 month ago

In the view you have send me I dont have any OT. /attendance/attendance-view/ Here:

Screenshot 2024-09-26 at 12 50 38

But here i have. attendance/attendance-overtime-view/

Screenshot 2024-09-26 at 12 51 43
Riiiad commented 1 month ago

And in the second there is not Bulk Option

horilla-opensource commented 1 month ago

Hi @Riiiad , The screenshot you have added in the previous comment is a bit confusing. The first screenshot with the url is correct.

But the screenshot and url given doesn't match. The second url (attendance/attendance-overtime-view/) you have mentioned is of Hour Account, but the screenshot is Attendance view.

PS: I think there is confusion with the terms and urls that are currently in the view. We apologize for that confusion. We are updating that section in our next version

Riiiad commented 1 month ago

Here is the Path you need to take to get to the confirm button: https://github.com/user-attachments/assets/700d761b-f2d0-4a7f-9539-7e614d4d69e3

Its not only the View that is Confusing. If it needs to be approved it should only be in the Approve OT Tab. But it seems only Overtimes above 1h are in the Tab. Then the Rest should be auto approved.

horilla-opensource commented 1 month ago

Can you share the Attendance Break Point settings screenshot?

Hi @Riiiad , Can you please share the Attendance Break Point settings inside the Settings ? Screenshot 2024-09-26 at 3 12 06 PM

Also can you please share the details of the Not Approved OT Hours column in the Hour Account view (marked in red in the screenshot) Screenshot 2024-09-26 at 3 13 39 PM

In case if you don't see this column, you can enable the column by clicking in the hamburger menu dot icon (marked green in the screenshot) and enabling that column.

Riiiad commented 1 month ago

Ok here it is: Image-1

horilla-opensource commented 1 month ago

Hi @Riiiad , From the Attendance Break Point condition you have setup, you need to have a minimum of 01:30 to have an overtime. But from the overtimes you have shared, there is no record which satisfy the minimum hour condition. That's why its not being displayed.

Please change the minimum hour for over time to a lower value and you'll be able to see the record inside the OT tab.

Riiiad commented 1 month ago

@horilla-opensource But that means that there is not Auto confirm is that correct. I have to Confirm even 1min OT.

horilla-opensource commented 1 month ago

Yes, in the current version there is no auto confirm. But the work is in progress for the auto confirm of overtime, just like the attendance validation which will soon be added to the system.