horizon-eda / horizon-pool-convention

0 stars 2 forks source link

Power pin positioning #7

Closed fruchti closed 3 years ago

fruchti commented 6 years ago

Sorry that it has taken me so long to open this issue. Now, it's finally here for you all to discuss!

There should be a rule where power pins have to be placed in symbols. KiCad says that they must be on the top and bottom of a symbol. I already had started a discussion with @carrotIndustries about this question before I started this convention attempt.

In my opinion, the “always on top/bottom” rule isn't optimal, but finding a concise alternative isn't easy. In the issue linked above I proposed some, which I want to summarise along with some subjective pros and cons.

I'd like to hear some more possibilities from you where the power pins could be and how we can boil that down into a rule.

carrotIndustries commented 6 years ago

https://github.com/carrotIndustries/horizon/commit/7c432b2b54b5d5af3461d63126da494c4da0bfeb adds support for horizontal text on vertical pins

fruchti commented 5 years ago

TBH, I'm still a fan of keeping the top and bottom of a (rectangular) symbol pin-free. It plays along nicely with most schematics' signal flow from left to right and doesn't take too much additional space. Some examples from KiCAD: 2018-12-02-153450_2476x1488_scrot 2018-12-02-153127_1211x1496_scrot

But aesthetics are a matter of opinion, of course. With the perpendicular pin names of https://github.com/carrotIndustries/horizon/commit/c345cf4fb5b7c380b64327ce597b0a2eba622223 a lot of the pain points for me of power pins on the top and bottom are addressed. If we want these pins on the top and bottom, I'd wager for having the same name orientation for all pins.

fruchti commented 5 years ago

As mentioned here, power pins on the top and bottom could look something like this: 2018-12-22-191326_1600x900_scrot If you want to play around, you can check out this symbol via its PR.

fruchti commented 5 years ago

@carrotIndustries, @atoav: Any comments on this?

fruchti commented 3 years ago

With the recent input from @carrotIndustries in https://github.com/horizon-eda/horizon-pool/pull/11#issuecomment-759699745 I’d consider this issue resolved for now. As always, I’m happy to re-open it if anyone has additional comments!